[PATCH] D99416: [lli] Add option -lljit-platform=Inactive to disable platform support explicitly

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added a comment.

This can be used to fix test failures on Windows when re-applying D98931 <https://reviews.llvm.org/D98931>



================
Comment at: llvm/tools/lli/lli.cpp:242
+                                     "Use LLJITMachOPlatform"),
+                          clEnumValN(LLJITPlatform::Inactive, "Inactive",
+                                     "Disable platform support explicitly")),
----------------
`Inactive` appeared to me as a sound term in code. Alternatives like No/None/Disabled/Passive seemed misleading in one or the other context (e.g. `setUp__Platform`).

For the option value I am uncertain. On the one hand it's always good to keep terms aligned, on the other hand it might be confusing the user. It could also be `Off` or something else.

What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99416/new/

https://reviews.llvm.org/D99416