[PATCH] D86222: Fix PR46880: Fail CHECK-NOT with undefined variable

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

You say there are many test failures.  Should I hold off reviewing the test changes already in this patch, or are those fine?



================
Comment at: llvm/lib/FileCheck/FileCheckImpl.h:232
   void log(raw_ostream &OS) const override {
-    OS << "\"";
-    OS.write_escaped(VarName) << "\"";
+    OS << "undefined variable: " << VarName;
   }
----------------
thopre wrote:
> jdenny wrote:
> > When is this function called now?
> It is a virtual function and thus needs to be defined. It's not called anywhere but I cannot remove it.
Makes sense.  So the point of the change here is, in case this function is one day called, to have a log message that is consistent with other `ErrorInfo` log messages now that old message here is no longer used by `printSubstitutions`.  Right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86222/new/

https://reviews.llvm.org/D86222