[PATCH] D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors

[Caroline via Phabricator via llvm-commits]

CarolineConcatto added inline comments.


================
Comment at: llvm/test/Analysis/CostModel/AArch64/sve-fpext.ll:10
+define void @sve_fpext() {
+  ; CHECK-LABEL: 'sve_fpext'
+  ; CHECK: Cost Model: Found an estimated cost of 1 for instruction:   %nxv2_f16_to_f32 = fpext <vscale x 2 x half> undef to <vscale x 2 x float>
----------------
I believe you can remove the space before ;
and I think you can use CHECK-NEXT


================
Comment at: llvm/test/Analysis/CostModel/AArch64/sve-fpext.ll:20
+  ; CHECK: Cost Model: Found an estimated cost of 6 for instruction:   %nxv8_f32_to_f64 = fpext <vscale x 8 x float> undef to <vscale x 8 x double>
+  %nxv2_f16_to_f32 = fpext <vscale x 2 x half> undef to <vscale x 2 x float>
+  %nxv4_f16_to_f32 = fpext <vscale x 4 x half> undef to <vscale x 4 x float>
----------------
Also add space between the last CHECK and the first instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98934/new/

https://reviews.llvm.org/D98934