[PATCH] D90352: Introduce a Bazel build configuration

Fri Mar 26 05:29:14 PDT 2021

csigg added inline comments.
Herald added subscribers: dcaballe, cota.

================
Comment at: utils/bazel/WORKSPACE:15
+
+load(":terminfo.bzl", "llvm_terminfo_from_env")
+
----------------
Downstream projects need to replicate everything in this WORKSPACE file, and it would therefore be good to keep it small.

My recommendation would be to move loading of external dependencies to llvm_configure, with the exception of
- load/call bazel_skylib_workspace(): this initializes a unittest toolchain and downstream project do not need it to depend on LLVM (I'm not even sure this repo uses it)
- load/call rbe_autoconfig(): downstream projects would need to replicate that plus copy and adjust the .bazelrc if they want to use a similar RBE setup.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90352/new/

https://reviews.llvm.org/D90352