[PATCH] D98963: [LoopVectorize] Change the identity element for FAdd

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D98963#2651724 <https://reviews.llvm.org/D98963#2651724>, @dmgreen wrote:

> What do you folks think for the context of this review? Is it best to have a go at adding that into instcombine, plus a fold to make phi + nsz + -0.0 use 0.0 instead. Or go with the initial version of this patch that just plumbs the nsz flag through and emits 0.0 for the nsz case?

Bending FMF propagation to match our goals is a multi-step process and will need more discussion to determine what is right/expected. So I am ok to go back to the initial version of the patch that checked nsz, but please put a FIXME comment there to state the ideal behavior and the mixed-zero problem that we're avoiding.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98963/new/

https://reviews.llvm.org/D98963