[PATCH] D95638: AMDGPU: Add target id and code object v4 support

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5085
+    raw_string_ostream StrOS(MetadataString);
+    for (size_t I = 0, E = Desc.size() / sizeof(PALMetadata); I < E; ++E) {
+      StrOS << "[" << Isa[I].Key << ": " << Isa[I].Value << "]";
----------------
@kzhuravl - this is a good example of why I want llvm-readobj testing for llvm-readobj code. There's a bug in this code (which I unfortunately introduced with my previous suggestion) which should have been easily picked up if it was properly tested. It should be `++I` not `++E`. Please fix ASAP, as it is being flagged up by our downstream static analyzer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95638/new/

https://reviews.llvm.org/D95638