[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

[Alexey Bader via Phabricator via llvm-commits]

bader added a comment.

In D89909#2624284 <https://reviews.llvm.org/D89909#2624284>, @aaron.ballman wrote:

> Based on the discussion so far, would these be acceptable steps to take?
>
> 0) Complete review on this patch for any technical concerns related to it and commit when it's ready (this unblocks some downstream needs quickly, hopefully).
>
> 1. @bader (or someone else on the SYCL team) creates a bare-bones SYCL documentation page that is quickly accepted as a placeholder for us to put more documentation.
> 2. Each new SYCL related review that needs user-facing documentation outside of what the SYCL standard documents will update the Clang SYCL doc.
> 3. @bader (or someone else on the SYCL team) writes address-space mapping documentation and adds it to the Clang SYCL doc.
> 4. @bader (or someone else on the SYCL team) looks at other commits that have already gone into Clang to write missing documentation.
>
> Some of these steps can be done in parallel, of course. I recognize we could have the order be #1 -> #3 -> #0 (so the docs for this change are written as part of this patch), but my concern with that approach is that this patch is blocking other SYCL efforts (@bader can correct me if I'm wrong about this) and no one has identified a definite issue with it yet beyond the lack of Clang documentation.
>
> If those steps seem unreasonable or like I've totally missed the point on something, perhaps we could reach an understanding more quickly via a meeting (we could summarize the decisions from the meeting here so the community is aware of the end results)?

@aaron.ballman, I've uploaded SYCL architecture design document with address space section (https://reviews.llvm.org/D99190).
I checked commits with SYCL functionality and we documented all extensions. In particular `sycl_kernel` attribute mentioned above is documented here - https://clang.llvm.org/docs/AttributeReference.html#sycl-kernel.
Are there any other steps I should do or we can consider it to be done?

Yesterday, we chatted offline and agreed that the main issue is missing documentation for Clang extensions being added for SYCL. To address this issue we are adding SYCL architecture design document, which we are going to update along with adding new features.

@Anastasia, @aaron.ballman, is there anything I can do for this patch to be accepted?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89909/new/

https://reviews.llvm.org/D89909