[PATCH] D99352: [AMDGPU] ds_read_*/ds_write_* operations require strict alignment.

Mahesha S via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 25 22:26:58 PDT 2021


hsmhsm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/ds_read2.ll:1038
+; GFX9-UNALIGNED-NEXT:  v_mov_b32_e32 v4, 0
+; GFX9-UNALIGNED-NEXT:  ds_read2_b64 v[0:3], v4 offset1:1
+; GFX9-UNALIGNED-NEXT:  s_load_dwordx2 s[0:1], s[0:1], 0x24
----------------
rampitec wrote:
> I would probably expect ds_read2_b32 for align 4.
The fix is further updated to take care of this - Now the allowsMisalignedMemoryAccessesImpl() checks for the strict alignment requirment for ds_read/ds_write operations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99352/new/

https://reviews.llvm.org/D99352



More information about the llvm-commits mailing list