[PATCH] D99395: [Propeller] Do not generate the BB address map for empty functions.
Rahman Lavaee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 25 19:40:12 PDT 2021
rahmanl marked an inline comment as done.
rahmanl added inline comments.
================
Comment at: llvm/test/CodeGen/X86/basic-block-sections-labels-empty-function.ll:11
+; CHECK: .Lfunc_begin0:
+; CHECK-NOT: .section .llvm_bb_addr_map
+
----------------
rahmanl wrote:
> tmsriram wrote:
> > Curious, How does this pass? There is a ".section .llvm_bb_addr_map" for func() later.
> Right. I learned it too. [FileCheck documentation](https://groups.google.com/a/google.com/g/propeller-info/c/Tq46RjCFVpc/m/4SSU0_JHDQAJ) says '//The “CHECK-NOT:” directive is used to verify that a string doesn’t occur between two matches//' So this CHECK-NOT is evaluated against the next CHECK.
Sorry. bad link above: https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-not-directive
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99395/new/
https://reviews.llvm.org/D99395
More information about the llvm-commits
mailing list