[PATCH] D99383: [GlobalISel] Add G_ROTR and G_ROTL opcodes for rotates

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:1584
+    LLT Src2Ty = MRI->getType(MI->getOperand(2).getReg());
+    if (DstTy.isVector() != Src1Ty.isVector() ||
+        Src1Ty.isVector() != Src2Ty.isVector()) {
----------------
```
def G_ROTR : GenericInstruction {
  let OutOperandList = (outs type0:$dst);
  let InOperandList = (ins type0:$src1, type1:$src2);
  let hasSideEffects = false;
}
```

IIUC `$dst` and `$src1` have the same type, so this check shouldn't be necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99383/new/

https://reviews.llvm.org/D99383