[PATCH] D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses

[Raoul Gough via Phabricator via llvm-commits]

drti added a comment.

In D98591#2627643 <https://reviews.llvm.org/D98591#2627643>, @ychen wrote:

> Could you add an example like `llvm/examples/Bye` and a test using `llc -load`?

I've made the changes to remove the filtering and simplify the test but I'm having some trouble with the Bye example. When I enable this via cmake ... -DLLVM_BYE_LINK_INTO_TOOLS=ON I get some test failures from llvm-check. Is that expected?

Failed Tests (6):

  LLVM :: Other/new-pm-O0-defaults.ll
  LLVM :: Other/opt-O0-pipeline.ll
  LLVM :: Other/opt-O2-pipeline.ll
  LLVM :: Other/opt-O3-pipeline-enable-matrix.ll
  LLVM :: Other/opt-O3-pipeline.ll
  LLVM :: Other/opt-Os-pipeline.ll

Example error output:

- TEST 'LLVM :: Other/opt-O3-pipeline-enable-matrix.ll' FAILED ********************

Script:
-------

: 'RUN: at line 1';   /home/raoul/build/llvm/head-static/bin/opt -enable-new-pm=0 -O3 -enable-matrix -debug-pass=Structure < /home/raoul/src/llvm/llvm-project/llvm/test/Other/opt-O3-pipeline-enable-matrix.ll -o /dev/null 2>&1 | /home/raoul/build/llvm/head-static/bin/FileCheck /home/raoul/src/llvm/llvm-project/llvm/test/Other/opt-O3-pipeline-enable-matrix.ll
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Exit Code: 1

Command Output (stderr):
------------------------

/home/raoul/src/llvm/llvm-project/llvm/test/Other/opt-O3-pipeline-enable-matrix.ll:216:15: error: CHECK-NEXT: is not on the line after the previous match
; CHECK-NEXT: Canonicalize natural loops

  ^

<stdin>:212:2: note: 'next' match was here
 Canonicalize natural loops
 ^
<stdin>:208:11: note: previous match ended here
 Early CSE

  ^

<stdin>:209:1: note: non-matching line after previous match is here
 Good Bye World Pass
^

Input file: <stdin>
Check file: /home/raoul/src/llvm/llvm-project/llvm/test/Other/opt-O3-pipeline-enable-matrix.ll

-dump-input=help explains the following input dump.

Input was:
<<<<<<

    .
    .
    .
  207:  Lower the matrix intrinsics 
  208:  Early CSE 
  209:  Good Bye World Pass 
  210:  Dominator Tree Construction 
  211:  Natural Loop Information 
  212:  Canonicalize natural loops 

next:216      !~~~~~~~~~~~~~~~~~~~~~~~~~  error: match on wrong line

  213:  LCSSA Verifier 
  214:  Loop-Closed SSA Form Pass 
  215:  Basic Alias Analysis (stateless AA impl) 
  216:  Function Alias Analysis Results 
  217:  Scalar Evolution Analysis 
    .
    .
    .

>>>>>> 



-


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98591/new/

https://reviews.llvm.org/D98591