[PATCH] D98884: [IR] Ignore bitcasts of function pointers which are only used as callees in callbase instruction

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 25 13:14:45 PDT 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/GlobalOpt.cpp:2147
+      for (User *BU : U->users())
+        SetCallBaseFastCallingConv(BU);
+      continue;
----------------
I do not see why a user of bitcast must be necessarily a call.


================
Comment at: llvm/lib/Transforms/IPO/GlobalOpt.cpp:2174
+      for (User *BU : U->users())
+        SetCallBaseAttributes(BU, F, A);
+      continue;
----------------
Same here, it is not necessarily a call.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98884/new/

https://reviews.llvm.org/D98884



More information about the llvm-commits mailing list