[PATCH] D99305: [docs] Document our norms around reverts

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 25 13:10:32 PDT 2021


reames marked 4 inline comments as done.
reames added a comment.

In D99305#2650472 <https://reviews.llvm.org/D99305#2650472>, @probinson wrote:

> Please add words to the effect of:  When re-landing a reverted patch, the commit message should be updated to indicate the problem that was addressed (bot failure, cite the PR, whatever).

Incorporated.

> (Separately, my personal peeve is that reverting a revert leads to headlines with a chain of "Revert "Revert "Revert ..." messages, which is really less than helpful.  By adding this new section, I'll have a place to introduce a suggestion to set the message to "Reland "original message"" or some such.)

While I personally agree with this, I've seen some disagreement on this.  Given that, I'll defer this addition to a separate change to keep this one simple and not controversial.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99305/new/

https://reviews.llvm.org/D99305



More information about the llvm-commits mailing list