[PATCH] D99371: [Utils][WIP] Allow multiple run lines with the same check prefix

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert created this revision.
Herald added a subscriber: arichardson.
Herald added a reviewer: bollu.
jdoerfert requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Note: Test for this is missing

When we include generated functions we don't want to generate the same
functions for each run lines that share a prefix.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99371

Files:
  llvm/utils/UpdateTestChecks/common.py


Index: llvm/utils/UpdateTestChecks/common.py
===================================================================
--- llvm/utils/UpdateTestChecks/common.py
+++ llvm/utils/UpdateTestChecks/common.py
@@ -880,15 +880,17 @@
 
 def add_checks_at_end(output_lines, prefix_list, func_order,
                       comment_string, check_generator):
-  added = set()
+  printed = set()
   for prefix in prefix_list:
     prefixes = prefix[0]
     tool_args = prefix[1]
     for prefix in prefixes:
       for func in func_order[prefix]:
-        if added:
+        if (prefix, func) in printed:
+            continue
+        if printed:
           output_lines.append(comment_string)
-        added.add(func)
+        printed.add((prefix, func))
 
         # The add_*_checks routines expect a run list whose items are
         # tuples that have a list of prefixes as their first element and


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99371.333403.patch
Type: text/x-patch
Size: 884 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210325/1ccd8880/attachment.bin>