[PATCH] D99347: [AMDGPU] Set implicit arg attributes for indirect calls

Madhur Amilkanthwar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 25 10:56:37 PDT 2021


madhur13490 marked an inline comment as done.
madhur13490 added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAnnotateKernelFeatures.cpp:277
+  // then add all attributes corresponding to the implicit args.
+  if (CallingConvSupportsAllImplicits && F.hasAddressTaken()) {
+    for (StringRef AttrName : ImplicitAttrNames) {
----------------
rampitec wrote:
> Pass all arguments to hasAddressTaken().
Ah, Right! missed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99347/new/

https://reviews.llvm.org/D99347



More information about the llvm-commits mailing list