[PATCH] D96363: Mark output as text if it is really text

[Abhina Sree via Phabricator via llvm-commits]

abhina.sreeskantharajan added a comment.

In D96363#2650904 <https://reviews.llvm.org/D96363#2650904>, @rnk wrote:

> This is why, in the past, we have taken the direction of opening all files as binary files. You have probably noticed all of the changes in this direction that you have to work around. I think the best solution here would be to add a new `OF_TextNoCrlf` mode that does what you need it to for System/Z, but opens the file in binary mode on Windows.

Right, adding a new flag like OF_TextNoCrlf is something I can look into as a solution. However, if Windows is always using binary mode and has no use for OF_Text flag, maybe I can globally set that mode similar to how I set it for ToolOutputFiles. I don't think any other platform is affected by the binary/text mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96363/new/

https://reviews.llvm.org/D96363