[PATCH] D99273: [DebugInfo] Support for signed constants inside DIExpression

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX updated this revision to Diff 333333.
SouraVX added a comment.

Thanks for the review @jmorse!

- Addressed review comments by @jmorse.
- Reinforced checks for both `isUnsignedConstant` and `isSignedConstant`.
- Added an `invalid` expression test case covering `isSignedConstant` 6 arguments case with operand 0 and operand 2 matching.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99273/new/

https://reviews.llvm.org/D99273

Files:
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/test/DebugInfo/X86/global-constants.ll
  llvm/test/DebugInfo/X86/invalid-global-constants.ll
  llvm/test/DebugInfo/X86/stack-value-dwarf4.ll
  llvm/test/Transforms/StripSymbols/strip-dead-debug-info.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99273.333333.patch
Type: text/x-patch
Size: 11641 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210325/5f2b76c4/attachment-0001.bin>