[PATCH] D99349: Fix: Reordering parameters in getFile and getFileOrSTDIN

Abhina Sree via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 25 08:45:29 PDT 2021


abhina.sreeskantharajan created this revision.
abhina.sreeskantharajan added a reviewer: tunz.
Herald added a subscriber: hiraditya.
abhina.sreeskantharajan requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

There was a new getFileOrSTDIN call added recently which was not included in my patch. https://reviews.llvm.org/D99110
I reordered the args to match the new order.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99349

Files:
  llvm/lib/ProfileData/Coverage/CoverageMapping.cpp


Index: llvm/lib/ProfileData/Coverage/CoverageMapping.cpp
===================================================================
--- llvm/lib/ProfileData/Coverage/CoverageMapping.cpp
+++ llvm/lib/ProfileData/Coverage/CoverageMapping.cpp
@@ -329,7 +329,7 @@
 
   for (const auto &File : llvm::enumerate(ObjectFilenames)) {
     auto CovMappingBufOrErr = MemoryBuffer::getFileOrSTDIN(
-        File.value(), /*FileSize=*/-1, /*RequiresNullTerminator=*/false);
+        File.value(), /*IsText=*/false, /*RequiresNullTerminator=*/false);
     if (std::error_code EC = CovMappingBufOrErr.getError())
       return errorCodeToError(EC);
     StringRef Arch = Arches.empty() ? StringRef() : Arches[File.index()];


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99349.333318.patch
Type: text/x-patch
Size: 702 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210325/5cf78556/attachment.bin>


More information about the llvm-commits mailing list