[PATCH] D99310: [deref] Handle byval/byref/sret/inalloc/preallocated arguments for deref-at-point semantics

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/IR/Value.cpp:747
+      if (ArgMemTy->isSized())
+        return false;
+
----------------
nikic wrote:
> Why is the check for a sized type necessary? For an unsized type there would be no dereferenceable bytes, but I don't think it's something that really affects canBeFreed itself?
I don't know.  It seemed like enough of a cornercase to preserve the conservative handling from elsewhere.  I'm happy to remove it if you are confident doing so is correct.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99310/new/

https://reviews.llvm.org/D99310