[PATCH] D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1
Abhina Sree via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 25 06:24:30 PDT 2021
abhina.sreeskantharajan added a comment.
I have a two nits, but overall LGTM, your patch may need to be rebased because CI is failing
================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:278
unsigned NumOperands = MI->getNumOperands();
+ bool EmitGNUAsmStartIndentationMarker =
+ MAI->getEmitGNUAsmStartIndentationMarker();
----------------
nit: Do we need to save this to a bool? We can just do the following if there is only one use.
if (MAI->getEmitGNUAsmStartIndentationMarker())
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98276/new/
https://reviews.llvm.org/D98276
More information about the llvm-commits
mailing list