[PATCH] D97813: [FileCheck] Fix -dump-input per-pattern diagnostic indexing

Thu Mar 25 01:24:12 PDT 2021

jhenderson added inline comments.

================
Comment at: llvm/test/FileCheck/dump-input/annotations.txt:524-548
+; RUN: echo 'text'   >  %t.in
+; RUN: echo 'labelA' >> %t.in
+; RUN: echo 'textA'  >> %t.in
+; RUN: echo 'labelB' >> %t.in
+; RUN: echo 'textB'  >> %t.in
+; RUN: echo 'labelC' >> %t.in
+; RUN: echo 'textC'  >> %t.in
----------------
jdenny wrote:
> jhenderson wrote:
> > Are you aware of the `split-file` utility? It allows you to write these sorts of inputs without needing mass echo lines, all in the same test file.
> I should try that.  Thanks!
> 
> However, that's a significant rewrite of this file.  Do you mind if I tuck that away for NFC work at some unspecified future date?
Yes, that's fine. I imagine there are a number of FileCheck tests that might benefit from it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97813/new/

https://reviews.llvm.org/D97813