[PATCH] D98963: [LoopVectorize] Change the identity element for FAdd

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 25 01:02:38 PDT 2021


dmgreen added a comment.

I think the original version was probably better, only doing this without nsz.  A vector like <0.0, -0.0, -0.0 -0.0> is going to be more difficult to materialize than one that is all zeros, without an obvious way of converting it to all zeros. And we should try to not pessimize the existing -Ofast cases.

Sorry, That was what I was trying to say above, it wasn't very clear.

If you change this back the the original, then it LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98963/new/

https://reviews.llvm.org/D98963



More information about the llvm-commits mailing list