[PATCH] D99048: [RFC][DebugInfo] Do not use the DBG_VALUE to calculate debug info of spill location

Yifeng Dong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 24 18:32:47 PDT 2021


dongAxis1944 added a comment.

In D99048#2647988 <https://reviews.llvm.org/D99048#2647988>, @jmorse wrote:

> Hmmmm, do you have a reduced reproducer in llvm-ir that could go in a bug report? There are a number of things that could be going on here, and we can't be sure which without an example.
>
> Given that the assembly you're using features a stack spill slot being shared by two values, I'd bet on stack slot colouring merging two slots and not modifying debug-info. Alternately, there are certain DBG_VALUEs that LiveDebugVariables produces which are hard for LiveDebugValues to interpret.
>
> For the actual modification in this patch:
>
> - I'm not sure what to make of the inliner codegen changes,
> - The VarLocBasedImpl LiveDebugValues change will drop a lot of other variable locations, which is undesirable.

Thanks for reviewing. I will upload the IR later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99048/new/

https://reviews.llvm.org/D99048



More information about the llvm-commits mailing list