[PATCH] D99311: [lld-macho] Add more TimeTraceScopes

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 24 17:54:51 PDT 2021


int3 added a subscriber: alexshap.
int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:1069-1080
+    {
+      TimeTraceScope timeScope("Gathering input sections");
+      // Gather all InputSections into one vector.
+      for (const InputFile *file : inputFiles) {
+        for (const SubsectionMap &map : file->subsections) {
+          for (const auto &p : map) {
+            InputSection *isec = p.second;
----------------
It's kind of silly that this takes a non-trivial amount of time. Perhaps that's where a chunk of the speedup in D98837 is coming from. Maybe once that lands we can remove this TimeTraceScope block.

cc @alexshap 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99311/new/

https://reviews.llvm.org/D99311



More information about the llvm-commits mailing list