[PATCH] D99287: [GlobalISel] Fix crash in RBS with a non-generic IMPLICIT_DEF.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 24 15:36:27 PDT 2021


aemerson added a comment.

In D99287#2648977 <https://reviews.llvm.org/D99287#2648977>, @arsenm wrote:

> In D99287#2648935 <https://reviews.llvm.org/D99287#2648935>, @paquette wrote:
>
>> LGTM. Kind of weird that we create normal IMPLICIT_DEFs in the IRTranslator though? I guess it's code shared with SDAG.
>
> Definitely shouldn't be doing that. No optimizations are going to recognize it

This falls under “already selected” code, and should have regclasses. The intention AFAIK is for GISel to allow targets to preselect code at any point in the pipeline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99287/new/

https://reviews.llvm.org/D99287



More information about the llvm-commits mailing list