[PATCH] D98564: [AArch64] Peephole rule to remove redundant cmp after cset.

Pavel Iliin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 24 15:29:12 PDT 2021


ilinpv marked 2 inline comments as done.
ilinpv added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1594
+  return CCIdx >= 0 ? static_cast<AArch64CC::CondCode>(
+                          Instr.getOperand(CCIdx).getImm())
+                    : AArch64CC::Invalid;
----------------
paquette wrote:
> We may want to assert that this is an immediate.
getImm() has an assert inside.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98564/new/

https://reviews.llvm.org/D98564



More information about the llvm-commits mailing list