[PATCH] D99287: [GlobalISel] Fix crash in RBS with a non-generic IMPLICIT_DEF.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/RegBankSelect.cpp:723
+      // Ignore IMPLICIT_DEF which must have a regclass.
+      if (MI.isImplicitDef())
+        continue;
----------------
arsenm wrote:
> How did this get past the isPreIselOpcode check (same with asm)?
Because the line above is short circuit AND, so it never calls `isPreISelOpcode()`. These opcodes are defined before the generic ones, so the `isTargetSpecificOpcode(MI)` call returns false.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99287/new/

https://reviews.llvm.org/D99287