[PATCH] D99219: [AArch64][GlobalISel] Mark G_SBFX/G_UBFX as legal for s32 and s64

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 24 11:11:33 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:705
 
+  getActionDefinitionsBuilder({G_SBFX, G_UBFX}).legalFor({s32, s64});
   computeTables();
----------------
If AArch64 doesn't support these without a constant, then they can't be legal. Legality cannot be contextual. This would need to be custom, and lower if not constant to be technically correct


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99219/new/

https://reviews.llvm.org/D99219



More information about the llvm-commits mailing list