[llvm] c5d53ef - [test] Fix mix of variable use/def and regex match

Thomas Preud'homme via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 24 10:58:13 PDT 2021


Author: Thomas Preud'homme
Date: 2021-03-24T17:58:16Z
New Revision: c5d53efeff5ca3943af6684e999c8802d9f48702

URL: https://github.com/llvm/llvm-project/commit/c5d53efeff5ca3943af6684e999c8802d9f48702
DIFF: https://github.com/llvm/llvm-project/commit/c5d53efeff5ca3943af6684e999c8802d9f48702.diff

LOG: [test] Fix mix of variable use/def and regex match

LLVM test Transforms/GlobalSplit/basic.ll mixes variable definition and
variable use with regex matching of end of line. Mixing end of line
matching with variable definition will work but not record the end of
line in the string variable. Mixing end of line with variable use will
ignore end of line and cause an error once D98691 is landed.

This commit moves the end of line matching out of the string subtitution
blocks.

Reviewed By: tejohnson

Differential Revision: https://reviews.llvm.org/D98854

Added: 
    

Modified: 
    llvm/test/Transforms/GlobalSplit/basic.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/GlobalSplit/basic.ll b/llvm/test/Transforms/GlobalSplit/basic.ll
index aa5b331a96ba..0a3724ffe3ee 100644
--- a/llvm/test/Transforms/GlobalSplit/basic.ll
+++ b/llvm/test/Transforms/GlobalSplit/basic.ll
@@ -12,8 +12,8 @@ target triple = "x86_64-unknown-linux-gnu"
 ]
 
 ; CHECK-NOT: @global =
-; CHECK: @global.0 = private constant [2 x i8* ()*] [i8* ()* @f1, i8* ()* @f2], !type [[T1:![0-9]+]], !type [[T2:![0-9]+]], !type [[T3:![0-9]+]], !vcall_visibility [[VIS:![0-9]+$]]
-; CHECK: @global.1 = private constant [1 x i8* ()*] [i8* ()* @f3], !type [[T4:![0-9]+]], !type [[T5:![0-9]+]], !vcall_visibility [[VIS$]]
+; CHECK: @global.0 = private constant [2 x i8* ()*] [i8* ()* @f1, i8* ()* @f2], !type [[T1:![0-9]+]], !type [[T2:![0-9]+]], !type [[T3:![0-9]+]], !vcall_visibility [[VIS:![0-9]+]]{{$}}
+; CHECK: @global.1 = private constant [1 x i8* ()*] [i8* ()* @f3], !type [[T4:![0-9]+]], !type [[T5:![0-9]+]], !vcall_visibility [[VIS]]{{$}}
 ; CHECK-NOT: @global =
 @global = internal constant { [2 x i8* ()*], [1 x i8* ()*] } {
   [2 x i8* ()*] [i8* ()* @f1, i8* ()* @f2],


        


More information about the llvm-commits mailing list