[PATCH] D99073: [lit] Reliable progress indicator and ETA

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D99073#2648210 <https://reviews.llvm.org/D99073#2648210>, @mstorsjo wrote:

> CC @goncharov
>
> It looks like this one is causing the Windows premerge checks to timeout, see e.g. the run for this particular patch: https://buildkite.com/llvm-project/premerge-checks/builds/30849
>
> When running `ninja check-lit` in a separate test setup on Windows, it fails (and hangs) with the following message:
>
>   Exception in thread Thread-3:
>   Traceback (most recent call last):
>     File "C:\Users\Administrator\AppData\Local\Programs\Python\Python39\lib\threading.py", line 954, in _bootstrap_inner
>       self.run()
>     File "C:\Users\Administrator\AppData\Local\Programs\Python\Python39\lib\threading.py", line 892, in run
>       self._target(*self._args, **self._kwargs)
>     File "C:\Users\Administrator\AppData\Local\Programs\Python\Python39\lib\multiprocessing\pool.py", line 592, in _handle_results
>       cache[job]._set(i, obj)
>     File "C:\Users\Administrator\AppData\Local\Programs\Python\Python39\lib\multiprocessing\pool.py", line 776, in _set
>       self._callback(self._value)
>     File "C:\code\llvm-project\llvm\build\bin\..\..\utils\lit\lit\display.py", line 98, in update
>       percent = self.progress_predictor.update(test)
>     File "C:\code\llvm-project\llvm\build\bin\..\..\utils\lit\lit\display.py", line 59, in update
>       return self.time_elapsed / total_time
>   ZeroDivisionError: float division by zero
>
> I went ahead and pushed a trivial fix for the division by zero. (As long as the patches that the premerge bot tests are based on a version of the monorepo before the division by zero fix though, the premerge jobs will hang and timeout I guess.)

Thanks!
How can `total_time` even be `0.0` there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99073/new/

https://reviews.llvm.org/D99073