[PATCH] D99249: [PassManager] Run additional LICM before LoopRotate

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 24 10:31:25 PDT 2021


nikic added a comment.

> I.e. we end up with less instructions, more LICM activity (+30% more sunks out of loops!),

This sounds too good to be true ... and it is. The statistic was closer to counting sinking candidates than actually sunk instructions. I've fixed it in 8a168d2d70678164004fca8de78e98bfb6e1272d <https://reviews.llvm.org/rG8a168d2d70678164004fca8de78e98bfb6e1272d> and would expect this patch to have a much more limited impact on it now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99249/new/

https://reviews.llvm.org/D99249



More information about the llvm-commits mailing list