[PATCH] D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token

[Abhina Sree via Phabricator via llvm-commits]

abhina.sreeskantharajan added inline comments.


================
Comment at: llvm/lib/MC/MCParser/AsmLexer.cpp:146
 
 /// LexIdentifier: [a-zA-Z_.][a-zA-Z0-9_$.@?]*
+static bool IsIdentifierChar(char c, bool AllowAt, bool AllowHash) {
----------------
nit: This comment should probably be updated to reflect the new changes.


================
Comment at: llvm/lib/MC/MCParser/AsmLexer.cpp:730
     if (MAI.doesAllowSymbolAtNameStart()) {
       // Handle Microsoft-style identifier: [a-zA-Z_$.@?][a-zA-Z0-9_$.@?]*
       if (!isDigit(CurChar) &&
----------------
same suggestion here as well. This comment may need to be updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99277/new/

https://reviews.llvm.org/D99277