[PATCH] D99206: Make FindAvailableLoadedValue TBAA aware

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:1394
+    AAMDNodes AATags;
+    LoadI->getAAMetadata(AATags);
+    const auto &DL = LoadI->getModule()->getDataLayout();
----------------
The AATags have already been extracted above (before the loop), so there should be no need to do so again here.


================
Comment at: llvm/test/Transforms/InstCombine/load-no-aliasing.ll:1
+; RUN: opt -tbaa -evaluate-aa-metadata -instcombine -S < %s | FileCheck %s
+
----------------
lebedev.ri wrote:
> Please precommit using `llvm/utils/update_test_checks.py`
The `-evaluate-aa-metadata` flag here is not needed -- this is used for directly printing modref information, not for normal transformation tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99206/new/

https://reviews.llvm.org/D99206