[PATCH] D99276: [ValueTracking] peek through min/max to find isKnownToBeAPowerOfTwo

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 24 09:30:57 PDT 2021


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/IR/PatternMatch.h:1738
     // it is the values returned by the select that are being compared.
-    Value *TrueVal = SI->getTrueValue();
-    Value *FalseVal = SI->getFalseValue();
-    Value *LHS = Cmp->getOperand(0);
-    Value *RHS = Cmp->getOperand(1);
+    auto *TrueVal = SI->getTrueValue();
+    auto *FalseVal = SI->getFalseValue();
----------------
Yeah, i think that's fine..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99276/new/

https://reviews.llvm.org/D99276



More information about the llvm-commits mailing list