[PATCH] D99212: [Support] Fix Windows 7 path handling

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth accepted this revision.
amccarth added a comment.

This looks even better.

I just found a comment in the Microsoft docs that suggests the problem _might_ have been avoided if any open handles to the file were created with FILE_SHARE_DELETE, but that sounds like a bigger change with a lot of potential side effects to think through, so I still prefer this localized fix.

In D99212#2646267 <https://reviews.llvm.org/D99212#2646267>, @aganea wrote:

> Yes, I've managed to repro the initial issue <https://github.com/rust-lang/rust/issues/81051> on a Windows 7 VM.
> The problem is easily reproducible with this Python snippet: https://pastebin.com/v51m3uBU

Yes, I understood the general issue.  I was just trying to reconcile the details report on one of the bug threads (Rust?) that reported that it was the second SetFileInformationByHandle call that failed.  That may have been true, but I suspect that was a cascading failure and the root problem was GetFInalPathNameByHandleW.

I don't have access to Windows 7, so I was unable to try it myself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99212/new/

https://reviews.llvm.org/D99212