[PATCH] D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer

[Victor Huang via Phabricator via llvm-commits]

NeHuang added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-tls-xcoff-variables.ll:11
+; RUN: llvm-readobj --syms %t.o | FileCheck --check-prefixes=SYMS,SYMS-NODATASECT %s
+; RUN: llvm-objdump -D --symbol-description %t.o | FileCheck --check-prefixes=OBJDUMP,OBJDUMP-NODATASECT %s
+
----------------
DiggerLin wrote:
> if do not use --symbol-description , I think llvm-objdump -D for -data-sections=on / off should be same.
yes, it will be same without adding `--symbol-description`. As discussed offline, we will keep `--symbol-description` to check the storaging mapping class in the dump. 


================
Comment at: llvm/test/CodeGen/PowerPC/aix-tls-xcoff-variables.ll:517
+
+ at tls_global_int_external_val_initialized = thread_local global i32 1, align 4
+ at tls_global_int_external_zero_initialized = thread_local global i32 0, align 4
----------------
DiggerLin wrote:
> suggest to remove the external from @tls_global_int_external_val_initialized , it is not a external variable. 
As discussed offline, we will keep these cases to check for tls variables with external linkage:
- zero initialized 
- value initialized 
- un-initialized (external reference)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98946/new/

https://reviews.llvm.org/D98946