[PATCH] D94395: [X86] AMD Znver3 Scheduler descriptions and llvm-mca tests

Wed Mar 24 06:24:48 PDT 2021

lebedev.ri added a comment.

In D94395#2647381 <https://reviews.llvm.org/D94395#2647381>, @RKSimon wrote:

> In D94395#2639387 <https://reviews.llvm.org/D94395#2639387>, @GGanesh wrote:
>
>> @lebedev.ri
>>
>> My colleague had submitted the libpfm4 patch to the libpfm4 community. You can take this patch and enablement for exegesis for znver3. Thank you for the help!
>
> @lebedev.ri No objections as long as @GGanesh is happy. What might be an issue is znver2/znver3 libpfm4 event lists are still missing the FPU pipe events, despite them being documented in the PPRs - this will mean that llvm-exegesis wouldn't be able to verify pipe allocation.
>
> I'll mention again that all the znver* models appear to be very inaccurate wrt SIMD/FPU instructions - so ensuring the existing znver1/znver2 models are correct must surely make sense - if it ends up being we copy+paste backwards from an accurate znver3 model then that works as well.

@GGanesh i agree with @RKSimon.
Having only cycle and uops counters is pretty limiting, having per-pipe counters would be awesome.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94395/new/

https://reviews.llvm.org/D94395