[PATCH] D99249: [PassManager] Run additional LICM before LoopRotate

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri updated this revision to Diff 332949.
lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.

In D99249#2647352 <https://reviews.llvm.org/D99249#2647352>, @thopre wrote:

> In D99249#2647330 <https://reviews.llvm.org/D99249#2647330>, @nikic wrote:
>
>> Just marking this to clarify that approval by @thopre is insufficient. Don't have time to review this right now.
>
> Indeed, I didn't approve it intentionally

Yep, not sure why that needed to be stated explicitly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99249/new/

https://reviews.llvm.org/D99249

Files:
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
  llvm/test/CodeGen/AMDGPU/opt-pipeline.ll
  llvm/test/Other/new-pm-defaults.ll
  llvm/test/Other/new-pm-thinlto-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-prelink-samplepgo-defaults.ll
  llvm/test/Other/opt-O2-pipeline.ll
  llvm/test/Other/opt-O3-pipeline-enable-matrix.ll
  llvm/test/Other/opt-O3-pipeline.ll
  llvm/test/Other/opt-Os-pipeline.ll
  llvm/test/Other/pass-pipelines.ll
  llvm/test/Transforms/IndVarSimplify/X86/pr45360.ll
  llvm/test/Transforms/PhaseOrdering/X86/spurious-peeling.ll
  llvm/test/Transforms/PhaseOrdering/X86/vdiv.ll
  llvm/test/Transforms/PhaseOrdering/loop-rotation-vs-common-code-hoisting.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99249.332949.patch
Type: text/x-patch
Size: 52896 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210324/de9e1907/attachment.bin>