[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

[Abhina Sree via Phabricator via llvm-commits]

abhina.sreeskantharajan marked 2 inline comments as done.
abhina.sreeskantharajan added inline comments.


================
Comment at: llvm/include/llvm/Support/MemoryBuffer.h:78-80
   /// if successful, otherwise returning null. If FileSize is specified, this
   /// means that the client knows that the file exists and that it has the
   /// specified size.
----------------
jhenderson wrote:
> You need to remove the reference to FileSize from the description here.
Thanks for catching that, I updated the comment.


================
Comment at: llvm/lib/Support/MemoryBuffer.cpp:108
 static ErrorOr<std::unique_ptr<MB>>
 getFileAux(const Twine &Filename, int64_t FileSize, uint64_t MapSize,
+           uint64_t Offset, bool IsText, bool RequiresNullTerminator,
----------------
jhenderson wrote:
> Are there users of the `FileSize` here? If not, can you repeat the change for this function?
No, I was able to remove FileSize from here as well as WritableMemoryBuffer::getFile too. Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99182/new/

https://reviews.llvm.org/D99182