[PATCH] D99249: [PassManager] Run additional LICM before LoopRotate

Wed Mar 24 05:40:13 PDT 2021

thopre added a comment.

In D99249#2647330 <https://reviews.llvm.org/D99249#2647330>, @nikic wrote:

> Just marking this to clarify that approval by @thopre is insufficient. Don't have time to review this right now.

Indeed, I didn't approve it intentionally

================
Comment at: llvm/test/Other/pass-pipelines.ll:54
 ; CHECK-O2-NEXT: FunctionPass Manager
 ; CHECK-O2-NOT: Manager
 ; CHECK-O2: Loop Pass Manager
----------------
lebedev.ri wrote:
> thopre wrote:
> > Shouldn't that CHECK-NOT be duplicated between each Loop Pass Manager check below as well?
> I don't know.
> This seems to be consistent with the previous checks, where there already were several LPM's,
> but no CHECK-NOT inbetween.
One of them was added a year ago by a different person than the author of the CHECK-NOT. I presume it was probably missed. Does the test pass if you add more CHECK-NOT?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99249/new/

https://reviews.llvm.org/D99249