[PATCH] D98967: [Analysis]Add getPointersDiff function to improve compile time.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 24 04:12:35 PDT 2021


ABataev added inline comments.


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:1226
+    for (const std::pair<int64_t, int> &Pair : Offsets) {
+      IsConsecutive = IsConsecutive && Cnt == Pair.second;
+      SortedIndices[Cnt] = Pair.second;
----------------
RKSimon wrote:
> @ABataev IsConsecutive is false so isn't this line redundant?
> 
> Noticed by static analysis.
Yes, just forgot to remove this line after rework. Will do thisnlater today.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98967/new/

https://reviews.llvm.org/D98967



More information about the llvm-commits mailing list