[PATCH] D99173: Intrinsic::getName: require a Module argument

Wed Mar 24 03:34:44 PDT 2021

fhahn added a comment.

Thanks for putting up this patch! I think it's preferable to D99066 <https://reviews.llvm.org/D99066>, because it ensures the `Module` is always available if it might be needed. It's probably also worth adding a note to the release notes?

================
Comment at: llvm/include/llvm-c/Core.h:2545
+ */
+const char *LLVMIntrinsicCopyOverloadedName2(unsigned ID,
+                                             LLVMTypeRef *ParamTypes,
----------------
Not sure about the name, but I think Eric's suggestion of `LLVMIntrinsicCopyOverloadedNameWithModule` on the list seems a bit more descriptive to me. Not sure what others think and naming is hard.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99173/new/

https://reviews.llvm.org/D99173