[PATCH] D99195: [RISCV] Optimize BUILD_VECTOR sequences that reveal hidden splats

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 24 03:22:13 PDT 2021


frasercrmck marked an inline comment as done.
frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1274
+    }
+
+    // Since we can't introduce illegal i64 types at this stage, we can only
----------------
craig.topper wrote:
> Do we need to sign extend SplatValue if the ViaIntVT is 32 and XLen is 64 bit to guarantee optimal constant materialization?
Ah yes of course. Thanks! Done, with a test to show its benefit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99195/new/

https://reviews.llvm.org/D99195



More information about the llvm-commits mailing list