[PATCH] D99252: [LoopFlatten] Fix invalid assertion (PR49571)

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 24 03:12:51 PDT 2021


SjoerdMeijer added inline comments.


================
Comment at: llvm/test/Transforms/LoopFlatten/pr49571.ll:3
+
+; CHECK-LABEL: @main
+
----------------
fhahn wrote:
> given that the test is very simple, I think it would be better to explicitly check the full output. Also, it would be helpful if you could add a comment explaining what scenario this tests
Ah yeah, agreed, I missed that. A follow up commit should do, if you're comfortable I don't think that needs another review, but I guess we are happy to look again of course. Definitely not needed to revert the first commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99252/new/

https://reviews.llvm.org/D99252



More information about the llvm-commits mailing list