[PATCH] D97813: [FileCheck] Fix -dump-input per-pattern diagnostic indexing

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

The code change looks fine. If I'm honest, I don't really follow the testing, but that's likely due to a lack of familiarity of the dump-input output format. If @thopre gets a chance to review, it'd probably be best.



================
Comment at: llvm/test/FileCheck/dump-input/annotations.txt:524-548
+; RUN: echo 'text'   >  %t.in
+; RUN: echo 'labelA' >> %t.in
+; RUN: echo 'textA'  >> %t.in
+; RUN: echo 'labelB' >> %t.in
+; RUN: echo 'textB'  >> %t.in
+; RUN: echo 'labelC' >> %t.in
+; RUN: echo 'textC'  >> %t.in
----------------
Are you aware of the `split-file` utility? It allows you to write these sorts of inputs without needing mass echo lines, all in the same test file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97813/new/

https://reviews.llvm.org/D97813