[PATCH] D97673: [RFC] [[Coroutine] [Debug] Salvage dbg.value at O2

[Xun Li via Phabricator via llvm-commits]

lxfind added a comment.

> I am not sure if `%0 = bit cast %a to ...` is the majority redundant fields of coroutine frame if we enable this patch. My original idea is to add a rematerialization process to reduce the coroutine frame like register allocation. However, it maybe a little hard and benefit less. It sounds more easy and beneficial to use original pointer by value tracking. Then I think this problem may be  not introduced by this patch. Here is my example:
>
>   %0 = bitcast %a to ...
>   call @llvm.coro.suspend 
>   ; ....
>   use of %a
>   use of %0
>
> Then both %a and %0 would be put in the frame, which is totally redundant. We could see if there are examples other than bit cast in other patch.

We already do materialization though. I wonder why that doesn't cover the case? Can we take advantage of that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97673/new/

https://reviews.llvm.org/D97673