[PATCH] D85288: [PowerPC] Remove implicit use register after transformToImmFormFedByLI()

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 21:49:11 PDT 2021


lkail planned changes to this revision.
lkail added a comment.

This fix looks not in a proper direction. If I remove lines `llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.cpp:[2259-2261)` in https://reviews.llvm.org/D56078, the test in this patch gets passed.
I tried dump `MI` and its `explicit_operands`, the output looks not what I expected.
Code modification

  if (SpecialShift32 || SpecialShift64) {
    MI.dump();
    for (auto &op : MI.explicit_operands()) {
      op.dump();
    }

Output

    renamable $x4 = exact RLDICL killed renamable $x4, killed renamable $r5, implicit $x5
  renamable $x4
  killed renamable $x4
  killed renamable $r5
  implicit $x5

`implicit $x5` is in the explicit operand list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85288/new/

https://reviews.llvm.org/D85288



More information about the llvm-commits mailing list