[PATCH] D98899: [DAE] Adjust param/arg attributes when changing parameter to undef

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM with two nits. Others can chime in if they dislike the wording.



================
Comment at: llvm/include/llvm/IR/Attributes.h:517-518
 
+  /// Remove noundef attribute and other attributes imply undef from this
+  /// attribute list. Returns a new list because attribute lists are immutable.
+  LLVM_NODISCARD AttributeList
----------------
I'd make this more explicit, here and below.


================
Comment at: llvm/include/llvm/IR/Attributes.h:520
+  LLVM_NODISCARD AttributeList
+  removeParamNoundefAttributes(LLVMContext &C, unsigned ArgNo) const;
+
----------------
Again, more explicit what this does, here and below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98899/new/

https://reviews.llvm.org/D98899