[PATCH] D98765: [Polly] Refactoring isReductionParallel() and getMinimalDependenceDistance() from Integer Set Libarary(ISL) to take the C++ wrapper

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

In D98765#2631785 <https://reviews.llvm.org/D98765#2631785>, @prateekpardeshi wrote:

> Changes made:
> making changes in code

For future updates, could you be more detailed?



================
Comment at: polly/include/polly/CodeGen/IslAst.h:163-164
   /// Get minimal dependence distance or nullptr if not available.
   static __isl_give isl_pw_aff *
-  getMinimalDependenceDistance(__isl_keep isl_ast_node *Node);
+  getMinimalDependenceDistance(const isl::ast_node &Node);
 
----------------
Meinersbur wrote:
> For the refactoring of this function to be complete, can you also make it return a `isl::pw_aff`?
Removing `__isl_give` is not the change I asked for,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98765/new/

https://reviews.llvm.org/D98765