[PATCH] D99217: [lld-macho] Fixed lld-version expectation in test so it works on Fuchsia.On Fuchsia, it's called Fuchsia LLD

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 16:17:45 PDT 2021


smeenai added inline comments.


================
Comment at: lld/test/MachO/dependency-info.s:18
 
-# CHECK: lld-version: LLD {{.*}}
+# CHECK: lld-version: {{.*}} LLD {{.*}}
 # CHECK-DAG: input-file: {{.*}}/bar.a
----------------
smeenai wrote:
> Tiny nit: I wouldn't have put an additional space here, to account for the case where there's no vendor in front of the "LLD". FileCheck uses non-strict whitespace by default though, so this also works. (See https://llvm.org/docs/CommandGuide/FileCheck.html#cmdoption-filecheck-strict-whitespace)
(ignore this; turns out non-strict whitespace doesn't kick in here)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99217/new/

https://reviews.llvm.org/D99217



More information about the llvm-commits mailing list